orastron/brickworks
2
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 10 Wiki Activity

fixed rounding bug when frequency is tiny and negative in bw_phase_gen

Browse Source
This commit is contained in:
Stefano D'Angelo 2023-10-17 16:36:27 +02:00
parent df05bf1740
commit 92e312766b
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
include/bw_phase_gen.h
View File

@ -20,7 +20,7 @@
/*! /*!
* module_type {{{ dsp }}} * module_type {{{ dsp }}}
* version {{{ 1.0.0 }}} * version {{{ 1.0.1 }}}
* requires {{{ bw_common bw_math bw_one_pole }}} * requires {{{ bw_common bw_math bw_one_pole }}}
* description {{{ * description {{{
* Phase generator with portamento and exponential frequency modulation. * Phase generator with portamento and exponential frequency modulation.
@ -29,6 +29,11 @@
* }}} * }}}
* changelog {{{ * changelog {{{
* <ul> * <ul>
* <li>Version <strong>1.0.1</strong>:
* <ul>
* <li>Fixed rouding bug when frequency is tiny and negative.</li>
* </ul>
* </li>
* <li>Version <strong>1.0.0</strong>: * <li>Version <strong>1.0.0</strong>:
* <ul> * <ul>
* <li>Added initial input value to * <li>Added initial input value to
@ -520,7 +525,7 @@ static inline void bw_phase_gen_update_coeffs_audio(
static inline float bw_phase_gen_update_phase( static inline float bw_phase_gen_update_phase(
bw_phase_gen_state * BW_RESTRICT state, bw_phase_gen_state * BW_RESTRICT state,
float inc) { float inc) {
state->phase += inc; state->phase += inc + 1.f; // + 1.f solves rounding issues with tiny negative frequencies
state->phase -= bw_floorf(state->phase); state->phase -= bw_floorf(state->phase);
return state->phase; return state->phase;
} }