From 399325359de263da598abdf4c3f93d57fdeefe86 Mon Sep 17 00:00:00 2001 From: Stefano D'Angelo Date: Mon, 14 Aug 2023 06:05:21 +0200 Subject: [PATCH] renamed bw_{drywet,ringmod} -> bw_{dry_wet,ring_mod} --- TODO | 11 +-- include/{bw_drywet.h => bw_dry_wet.h} | 101 ++++++++++++------------ include/bw_reverb.h | 24 +++--- include/{bw_ringmod.h => bw_ring_mod.h} | 85 ++++++++++---------- include/bw_trem.h | 20 ++--- 5 files changed, 120 insertions(+), 121 deletions(-) rename include/{bw_drywet.h => bw_dry_wet.h} (63%) rename include/{bw_ringmod.h => bw_ring_mod.h} (67%) diff --git a/TODO b/TODO index 09b28cc..b60e0c0 100644 --- a/TODO +++ b/TODO @@ -31,7 +31,6 @@ code: * mem req -> return value of set sample rate? * peak gain + Q ??? * sr_reduce reset_coeffs? update_coeffs? process_multi? -* drywet -> dry_wet, ringmod -> ring_mod, etc? * allow nullptr in C++ wrappers where process_multi arg can be NULL * better src filter * c++ get coeffs/state? or public? src nIn/OutSamples case (array vs single value), delay read/write, process1? process single? @@ -39,6 +38,8 @@ code: * clearly specify that state is tied to a particular set of coeffs (1:N) * modulation vs process (multi) no update (post 1.0.0)??? * check assumptions w.r.t. usage of math functions +* sample rate-constant coeffs? (pan case) +* sr-dependent vs cr-dependent coeffs? see synth poly example build system: * single header generation (vs modules in bwp... to think about) @@ -68,6 +69,8 @@ code: * process (multi) no update * examples cpu usage * bw_math: review types in implementation +* way to detect extern "C"? perhaps hidden "trap" preprocessor definition? +* any chance to avoid casts in C for const X * const * input arguments? build system: * make makefiles handle paths with spaces etc @@ -81,9 +84,3 @@ build system: * cross compile (rpi etc.) * better use of xcodegen (see xcode warnings) and/or consider tuist (https://tuist.io/), bazel (https://bazel.build/), pants (https://www.pantsbuild.org/), buck (https://buck2.build/), please (https://please.build/index.html) for mobile apps * homogenize android and ios common code (e.g., same index) - --- - -code: -* sample rate-constant coeffs? (pan case) -* sr-dependent vs cr-dependent coeffs? see synth poly example diff --git a/include/bw_drywet.h b/include/bw_dry_wet.h similarity index 63% rename from include/bw_drywet.h rename to include/bw_dry_wet.h index f636ee5..3a8f77c 100644 --- a/include/bw_drywet.h +++ b/include/bw_dry_wet.h @@ -29,8 +29,9 @@ *